feat: syncrhonize restricted course runs #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
force-pushed
the
aed/sync-restricted-runs
branch
3 times, most recently
from
abbb3db to
c392ba7
Compare
pwnage101
approved these changes
Oct 17, 2024
Comment on lines
904
to
915
| @staticmethod | ||
| def allowed_runs_for_course(course_metadata_dict, catalog_query): | ||
| """ | ||
| Given a ``course_metadata_dict``, returns a filtered list of ``course_runs`` | ||
| containing only unrestricted runs and restricted runs that are allowed by | ||
| the provided ``catalog_query``. | ||
| """ | ||
| allowed_restricted_runs = catalog_query.restricted_runs_allowed.get(course_metadata_dict['key'], []) | ||
| return [ | ||
| run for run in course_metadata_dict['course_runs'] | ||
| if run.get(COURSE_RUN_RESTRICTION_TYPE_KEY) is None or run['key'] in allowed_restricted_runs | ||
| ] |
There was a problem hiding this comment.
Nit: I think this would be more self-documenting if it composed restricted_runs_for_course(), then simply appended all unrestricted runs.
iloveagent57
force-pushed
the
aed/sync-restricted-runs
branch
from
c392ba7 to
23a80a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-9570
Updates or creates restricted course run metadata records when restricted courses are updated, and links the restricted run content to the restricted course. Note this makes additional call to discovery's
search/all/endpoint for restricted run metadata, one per query that allows restricted runs.Post-review