Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added feature to hide delete button for countries #1176

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

muhammadadeeltajamul
Copy link
Contributor

Description

Added feature to hide delete button for countries.

Ticket: INF-1743

Video after changes:

Screen.Recording.2024-12-18.at.4.55.22.PM.mov

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.51%. Comparing base (45ea5a7) to head (4174ee1).
Report is 2 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/account-settings/AccountSettingsPage.jsx 28.57% 5 Missing ⚠️
src/index.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1176      +/-   ##
===========================================
- Coverage    58.64%   58.51%   -0.14%     
===========================================
  Files          117      117              
  Lines         2336     2343       +7     
  Branches       646      653       +7     
===========================================
+ Hits          1370     1371       +1     
- Misses         905      911       +6     
  Partials        61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhammadadeeltajamul muhammadadeeltajamul merged commit c6fa214 into 2u-main Dec 19, 2024
6 of 8 checks passed
@muhammadadeeltajamul muhammadadeeltajamul deleted the inf-1743 branch December 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants