Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate deprecated Table to DataTable for EnrolledLearnersTable #1280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented Aug 23, 2024

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Screenshot

Screenshot 2024-09-05 at 1 28 51 PM

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-8444 branch 9 times, most recently from 5830d17 to b75845e Compare September 4, 2024 10:45
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 37.73585% with 33 lines in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (115c430) to head (a7336f5).

Files with missing lines Patch % Lines
...ledLearnersTable/data/hooks/useEnrolledLearners.js 24.39% 25 Missing and 6 partials ⚠️
src/components/EnrolledLearnersTable/index.jsx 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   85.52%   85.31%   -0.21%     
==========================================
  Files         564      565       +1     
  Lines       12351    12400      +49     
  Branches     2621     2627       +6     
==========================================
+ Hits        10563    10579      +16     
- Misses       1729     1756      +27     
- Partials       59       65       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-8444 branch 7 times, most recently from 13fe16c to 3c9fc01 Compare September 12, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant