feat: integrate advance analytics charts #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-ammar
force-pushed
the
ammar/integrate-advance-analytics-charts
branch
3 times, most recently
from
7279e0e to
ac811d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
- Coverage 85.51% 85.48% -0.04%
==========================================
Files 562 564 +2
Lines 12295 12303 +8
Branches 2601 2564 -37
==========================================
+ Hits 10514 10517 +3
- Misses 1722 1728 +6
+ Partials 59 58 -1 ☔ View full report in Codecov by Sentry. |
muhammad-ammar
force-pushed
the
ammar/integrate-advance-analytics-charts
branch
2 times, most recently
from
118b5c3 to
33f1856
Compare
jajjibhai008
reviewed
Sep 4, 2024
| }} | ||
| loadingMessage={intl.formatMessage({ | ||
| id: 'advance.analytics.completions.tab.chart.top.courses.by.completions.loading.message', | ||
| defaultMessage: 'Loading top courses by completions chart data', |
There was a problem hiding this comment.
Please follow the camelCase pattern to write the IDs of marked strings.
jajjibhai008
reviewed
Sep 4, 2024
| tableColumns: PropTypes.arrayOf(PropTypes.shape({})).isRequired, | ||
| tableTitle: PropTypes.string.isRequired, | ||
| tableSubtitle: PropTypes.string.isRequired, | ||
| enableCSVDownload: PropTypes.bool.isRequired, |
There was a problem hiding this comment.
[Suggestion] We could make it a bit more efficient by giving it a default false value. By this, we just need to pass this variable from those charts where we want to enable the download CSV button.
muhammad-ammar
force-pushed
the
ammar/integrate-advance-analytics-charts
branch
from
edad54e to
3f786ef
Compare
muhammad-ammar
added
the
plotly-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
JIRA:
For all changes
Only if submitting a visual change