Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paginators on reporting configurations page #1362

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Dec 3, 2024

Description

Added Paginations on the Reporting Configurations page:

image

Here is the orignal PR #1361

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (371f043) to head (ddf02a9).

Files with missing lines Patch % Lines
src/components/ReportingConfig/index.jsx 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
+ Coverage   85.72%   85.79%   +0.07%     
==========================================
  Files         609      609              
  Lines       13363    13384      +21     
  Branches     2812     2821       +9     
==========================================
+ Hits        11455    11483      +28     
+ Misses       1838     1831       -7     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9768-2 branch from e6fcf2a to 6367c41 Compare December 4, 2024 11:43
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9768-2 branch from 6367c41 to ddf02a9 Compare December 16, 2024 09:13
@jajjibhai008 jajjibhai008 merged commit 383989c into master Dec 16, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9768-2 branch December 16, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants