Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creates a modal to add members #1363

Merged
merged 8 commits into from
Jan 7, 2025
Merged

feat: creates a modal to add members #1363

merged 8 commits into from
Jan 7, 2025

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Dec 4, 2024

Description

Creates a modal to add members to an existing group
https://2u-internal.atlassian.net/browse/ENT-9602

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review December 10, 2024 16:42
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 86.76471% with 27 lines in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (0847890) to head (bcfd87a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...agement/AddMembersModal/AddMembersModalContent.jsx 84.21% 6 Missing ⚠️
...ement/data/hooks/useEnterpriseLearnersTableData.js 0.00% 5 Missing ⚠️
...opleManagement/AddMembersModal/AddMembersModal.jsx 89.47% 4 Missing ⚠️
src/data/services/LmsApiService.js 20.00% 4 Missing ⚠️
...dMembersModal/AddMemberModalSummaryLearnerList.jsx 81.25% 3 Missing ⚠️
...mponents/PeopleManagement/AddMembersBulkAction.jsx 84.61% 2 Missing ⚠️
...AddMembersModal/AddMemberModalSummaryDuplicate.jsx 50.00% 1 Missing ⚠️
...nents/PeopleManagement/RemoveMembersBulkAction.jsx 88.88% 1 Missing ⚠️
...gement/data/hooks/useAllEnterpriseGroupLearners.js 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
- Coverage   85.80%   85.79%   -0.01%     
==========================================
  Files         610      623      +13     
  Lines       13430    13589     +159     
  Branches     2826     2851      +25     
==========================================
+ Hits        11523    11659     +136     
- Misses       1837     1860      +23     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 self-requested a review December 12, 2024 21:42
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! There one little problem with data table selected numbers that we might want to look into though (says zero selected after I've selected 3 new members)
Screenshot 2025-01-06 at 4 22 37 PM

@katrinan029 katrinan029 merged commit 1fa9064 into master Jan 7, 2025
5 of 6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9602 branch January 7, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants