Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flex group filtering on lpr page #1371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omar-sarfraz
Copy link
Member

@omar-sarfraz omar-sarfraz commented Dec 24, 2024

Added a dropdown on LPR page to enable filtering based on groups for an enterprise.

Jira Ticket: ENT-9773

Depends On: PR

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots
image

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (a13b2a7) to head (3fac5cd).

Files with missing lines Patch % Lines
src/containers/AdminPage/index.jsx 50.00% 2 Missing ⚠️
src/data/actions/enterpriseGroups.js 84.61% 2 Missing ⚠️
src/components/Admin/AdminSearchForm.jsx 94.11% 1 Missing ⚠️
src/utils.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1371      +/-   ##
==========================================
+ Coverage   85.79%   85.81%   +0.01%     
==========================================
  Files         623      626       +3     
  Lines       13589    13644      +55     
  Branches     2851     2865      +14     
==========================================
+ Hits        11659    11708      +49     
- Misses       1860     1866       +6     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
Could you please add the ticket link and a small description of the changes?

@omar-sarfraz omar-sarfraz force-pushed the osarfraz/ENT-9773 branch 2 times, most recently from a0918ad to 840a0bf Compare December 31, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants