Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate insights before rendering analytics summary & improve error message #1372

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mahamakifdar19
Copy link
Contributor

Ticket:
https://2u-internal.atlassian.net/browse/ENT-8817

Description:
For test enterprises, there is incomplete data in analytics, which was causing the analytics-summary API to return a bad request error. A validation check has been added to ensure the Summarize Analytics button is only displayed for users with complete insights data, against which the analytics summary can be tailored.
Additionally, the error message has been improved to provide clearer information in case of any technical issues.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (fdc0a9a) to head (01d5fda).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   85.79%   85.80%           
=======================================
  Files         610      610           
  Lines       13429    13430    +1     
  Branches     2825     2826    +1     
=======================================
+ Hits        11522    11523    +1     
  Misses       1837     1837           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit b0341f4 into master Jan 6, 2025
6 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-8817 branch January 6, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants