Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9879] Add truthy check for null ordering parameter #1374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahamakifdar19
Copy link
Contributor

Ticket:
https://2u-internal.atlassian.net/browse/ENT-9879

Description:
Added a truthy check for the ordering parameter to ensure the application does not throw runtime errors when the ordering query parameter is temporarily missing or null.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (a13b2a7) to head (34a0859).

Files with missing lines Patch % Lines
src/components/TableComponent/index.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
+ Coverage   85.79%   85.81%   +0.01%     
==========================================
  Files         623      623              
  Lines       13589    13590       +1     
  Branches     2851     2856       +5     
==========================================
+ Hits        11659    11662       +3     
+ Misses       1860     1858       -2     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A patch coverage check is failing. Other than that LGTM

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-9879 branch 2 times, most recently from d58a729 to a806f2c Compare January 10, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants