ENT-9308: Added user first and last name for LPR. #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleem-latif
requested review from
muhammad-ammar,
irfanuddinahmad,
jajjibhai008,
omar-sarfraz and
mahamakifdar19
saleem-latif
force-pushed
the
saleem-latif/ENT-9308
branch
from
048debf to
6e79932
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1376 +/- ##
=======================================
Coverage 85.79% 85.79%
=======================================
Files 623 623
Lines 13589 13589
Branches 2810 2851 +41
=======================================
Hits 11659 11659
Misses 1860 1860
Partials 70 70 ☔ View full report in Codecov by Sentry. |
muhammad-ammar
approved these changes
Jan 9, 2025
jajjibhai008
reviewed
Jan 9, 2025
| { | ||
| label: intl.formatMessage({ | ||
| id: 'adminPortal.enrollmentsTable.user_first_name', | ||
| defaultMessage: 'First Name', |
There was a problem hiding this comment.
Aren't we supposed to add the description of the message as well?
jajjibhai008
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: 9308
Description:
This PR introduces 2 new columns
First NameandLast Namefor learner progress report table.Screenshot: