Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show groups cards zero state while groups data is loading #1380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marlonkeating
Copy link
Contributor

Jira Ticket

This change adds a loading skeleton for the groups cards section while groups are loading.

Testing Instructions

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (0716be5) to head (0012fdc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1380   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files         625      625           
  Lines       13638    13641    +3     
  Branches     2856     2812   -44     
=======================================
+ Hits        11690    11693    +3     
  Misses       1878     1878           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant