Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix recommendations card subtitle #1070

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

zainab-amir
Copy link
Contributor

Description

Fixed issue with subtitle on recommendations card.

JIRA

VAN-1657

How Has This Been Tested?

Locally

Screenshots/sandbox (optional):

Before After
Screenshot 2023-09-08 at 12 23 27 PM Screenshot 2023-10-06 at 2 29 47 PMScreenshot 2023-10-06 at 2 31 55 PM

@zainab-amir zainab-amir requested a review from a team as a code owner October 6, 2023 09:36
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we get this limit from edx.org?

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4df13cf) 86.96% compared to head (293be9b) 86.97%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   86.96%   86.97%           
=======================================
  Files         124      124           
  Lines        2264     2265    +1     
  Branches      624      624           
=======================================
+ Hits         1969     1970    +1     
  Misses        286      286           
  Partials        9        9           
Files Coverage Δ
src/recommendations/ProductCard/BaseCard/index.jsx 100.00% <ø> (ø)
src/recommendations/data/utils.js 87.50% <100.00%> (+0.40%) ⬆️
src/config/index.js 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zainab-amir
Copy link
Contributor Author

No. I used it based on the design.

@zainab-amir zainab-amir merged commit 7b4714a into master Oct 6, 2023
5 of 6 checks passed
@zainab-amir zainab-amir deleted the zamir/VAN-1657/fix_recommendations_card_design branch October 6, 2023 10:58
snglth pushed a commit to Abstract-Tech/community-theme-authn that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants