-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: content centering and z-index position on adaptation #1094
fix: content centering and z-index position on adaptation #1094
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 124 124
Lines 2276 2276
Branches 634 634
=======================================
Hits 1982 1982
Misses 285 285
Partials 9 9 ☔ View full report in Codecov by Sentry. |
hi @openedx/vanguards! This is ready for review / merge. |
I have approved the PR but you need to rebase the branch with base branch. Once you do it I will merge with master. |
@ahtesham-quraish Rebased |
@ihor-romaniuk unfortunately its still out-of-date |
@zainab-amir Rebased, please check one more time. |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This pull request contains recommendations for fixing block indentation (make it decimal) and correct display of the header (z-index of the header) during adaptation.
Related Pull Requests
PR to the open-release/palm.master branch: #1095
PR to the open-release/quince.master branch: #1093
Screenshots
Merge Checklist
Post-merge Checklist