Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser header showing null and replace authn with Authentication #1185

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

hinakhadim
Copy link
Contributor

Description

When accessing Authn MFE for the first time it shows "Auth | null" in the browser header. This PR will fix If process.env.SITE_NAME is not available it will show “Authentication” otherwise show “Authentication | {site_name}”. This bug (#1158) has been fixed in #1168 but still not resolve. As process.env.SITE_NAME is null but in index.html, it assumes null as a string value and passed the condition which is expected to be failed. As a result, still showing Authn | null. Moreover, in this PR, I have replaced Authn with the Authentication as suggested here.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Before After
auth2 authn1

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (ca42f38) to head (97b270c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1185   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files         127      127           
  Lines        2398     2398           
  Branches      680      680           
=======================================
  Hits         2022     2022           
  Misses        356      356           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zainab-amir zainab-amir merged commit 56bab26 into openedx:master Mar 4, 2024
7 checks passed
@zainab-amir zainab-amir added the open-source-contribution PR author is not from Axim or 2U label Mar 4, 2024
@arbrandes
Copy link
Contributor

I would've approved the fix, too, but at some point we should just start using react-helmet everywhere, like other MFEs already do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants