fix: browser header showing null and replace authn with Authentication #1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When accessing Authn MFE for the first time it shows "Auth | null" in the browser header. This PR will fix If process.env.SITE_NAME is not available it will show “Authentication” otherwise show “Authentication | {site_name}”. This bug (#1158) has been fixed in #1168 but still not resolve. As
process.env.SITE_NAME
isnull
but inindex.html
, it assumesnull
as a string value and passed the condition which is expected to be failed. As a result, still showingAuthn | null
. Moreover, in this PR, I have replacedAuthn
with theAuthentication
as suggested here.How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots/sandbox (optional):