fix: the display of username suggestions #1279
Open
+32
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Username suggestions functionality has been corrected to ensure proper behaviour.
Related Pull Requests
PR to the open-release/quince.master branch: #1278
PR to the master branch: #1270
Steps to Reproduce:
1. suggestions being displayed in the wrong place
Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> Click on field "Public username"
suggestions_rendering_bug.mov
2. impossible to enter suggestions field using the keyboard
Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> press Tab button until you get to the "Public username" field
suggestions_keyboard.mov
After changes:
1. suggestions being displayed in the wrong place
fixed_suggestions_rendering_bug.mov
2. impossible to enter suggestions field using the keyboard
fixed_suggestions_keyboard.mov
Merge Checklist
Post-merge Checklist