Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed duplicate event firing on post SSO login registration #1381

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ayesha-waris
Copy link

INF-1721

Description

fix cohesion duplicate events post SSO login/registration

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (1477ed3) to head (772e182).
Report is 53 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/login/LoginPage.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1381      +/-   ##
===========================================
- Coverage    86.57%   86.38%   -0.19%     
===========================================
  Files          134      139       +5     
  Lines         2413     2454      +41     
  Branches       669      675       +6     
===========================================
+ Hits          2089     2120      +31     
- Misses         311      319       +8     
- Partials        13       15       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update test case according to new condition.

@ayesha-waris ayesha-waris merged commit cd20039 into 2u-main Nov 27, 2024
4 of 6 checks passed
@ayesha-waris ayesha-waris deleted the Ayesha/INF-1721 branch November 27, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants