feat: refactor after review

openedx · Apr 24, 2024 · 34d8fa1 · 34d8fa1
1 parent 134dac9
commit 34d8fa1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/CourseAuthoringRoutes.jsx b/src/CourseAuthoringRoutes.jsx
@@ -127,7 +127,7 @@ const CourseAuthoringRoutes = () => {
           element={<PageWrap><Certificates courseId={courseId} /></PageWrap>}
         />
         <Route
-          path="/textbooks"
+          path="textbooks"
           element={<PageWrap><Textbooks courseId={courseId} /></PageWrap>}
         />
       </Routes>

diff --git a/src/generic/modal-dropzone/useModalDropzone.jsx b/src/generic/modal-dropzone/useModalDropzone.jsx
@@ -49,7 +49,8 @@ const useModalDropzone = ({
    */
   const constructAcceptObject = (types) => types
     .reduce((acc, type) => {
-      const mimeType = VALID_IMAGE_TYPES.includes(type) ? 'image/*' : '*/*';
+      // eslint-disable-next-line no-nested-ternary
+      const mimeType = type === 'pdf' ? 'application/pdf' : VALID_IMAGE_TYPES.includes(type) ? 'image/*' : '*/*';
       if (!acc[mimeType]) {
         acc[mimeType] = [];
       }

diff --git a/src/textbooks/textbook-card/TextbooksCard.jsx b/src/textbooks/textbook-card/TextbooksCard.jsx
@@ -44,7 +44,7 @@ const TextbookCard = ({
   const { tabTitle, chapters, id } = textbook;
 
   const onPreviewTextbookClick = () => {
-    window.location.href = `${config.LMS_BASE_URL}/courses/${courseId}/pdfbook/${textbookIndex}/`;
+    window.open(`${config.LMS_BASE_URL}/courses/${courseId}/pdfbook/${textbookIndex}/`, '_blank');
   };
 
   const handleDeleteButtonSubmit = () => {