-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: iframe rendering optimization #1544
base: master
Are you sure you want to change the base?
chore: iframe rendering optimization #1544
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by @openedx/2u-tnl. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
2b254df
to
59f96a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
+ Coverage 93.25% 93.30% +0.05%
==========================================
Files 1100 1100
Lines 21794 21791 -3
Branches 4702 4718 +16
==========================================
+ Hits 20323 20333 +10
+ Misses 1399 1387 -12
+ Partials 72 71 -1 ☔ View full report in Codecov by Sentry. |
9c320e4
to
f290f99
Compare
refactor: corrected scroll to target xblock refactor: fixed scroll behavior to xblock element refactor: after rebase refactor: fixed tests refactor: updated tests
f290f99
to
4168e54
Compare
Sandbox deployment successful 🚀 |
@@ -1,6 +1,7 @@ | |||
.DS_Store | |||
.eslintcache | |||
.idea | |||
.run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] Do we need to extend the .gitignore
with this directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that if we already have a .idea
folder that is created by the development environment, why not add .run
too?
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
b0c2570
to
b0faf3f
Compare
Sandbox deployment successful 🚀 |
🚨 Dependencies:
Description
This PR provides iframe reload optimizations for various xblock related actions. Added some improvements related to scrolling to the current xblock. Fixed behavior of the xblock action dropdown list.
Testing instructions
Screen.Recording.2025-01-20.at.9.21.47.AM.mov
Other information
Improvements to the editing modals and tagging will be added in future PRs.
Settings