-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AdvancedEditors with an iframe [FC-0076] #1568
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @ChrisChV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
+ Coverage 92.94% 92.97% +0.02%
==========================================
Files 1073 1076 +3
Lines 21098 21206 +108
Branches 4479 4483 +4
==========================================
+ Hits 19610 19716 +106
- Misses 1422 1424 +2
Partials 66 66 ☔ View full report in Codecov by Sentry. |
c547d84
to
c0f84ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: Ran the testing instructions
- I read through the code
- I checked for accessibility issues
- Includes documentation
Description
Creates the
AdvancedEditor
to support editors like Drag and Drop, openresponse, poll, survey, and other advanced editors.Follow this discovery for next steps.
AdvancedEditor
created to callstudio_view
of the blockLibraryBlock
to support any view (and usestudio_view
inAdvancedEditor
)cancel-clicked
message to close the Advanced editor.Useful information to include:
Supporting information
Testing instructions
LIBRARY_SUPPORTED_BLOCKS="problem,video,html,poll,drag-and-drop-v2,lti_consumer,google-document,survey"
in.env.development
Advanced module list
add:Other information
N/A