-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add accessibility page #861
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #861 +/- ##
==========================================
+ Coverage 90.94% 91.01% +0.06%
==========================================
Files 520 530 +10
Lines 9157 9226 +69
Branches 1920 1935 +15
==========================================
+ Hits 8328 8397 +69
Misses 797 797
Partials 32 32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is just a draft, but I was curious. :)
}, | ||
a11yBodyIntroGraph: { | ||
id: 'a11yBodyIntroGraph', | ||
defaultMessage: `At edX, we seek to understand and respect the unique needs and perspectives of the edX global community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage: `At edX, we seek to understand and respect the unique needs and perspectives of the edX global community. | |
defaultMessage: `We seek to understand and respect the unique needs and perspectives of the global community. |
Do you mind making sure there aren't any instances of edX being referenced specifically in the messages?
}, | ||
accessibilityPolicyFormSuccess: { | ||
id: 'accessibilityPolicyFormSuccess', | ||
defaultMessage: 'Thank you for contacting edX!', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage: 'Thank you for contacting edX!', | |
defaultMessage: 'Thank you for contacting us!', |
Another example of the above. (There are more, I just didn't tag them explicitly.)
const communityAccessibilityLink = 'https://www.edx.org/accessibility'; | ||
const email = '[email protected]'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this will become configurable before the PR gets out of draft; just checking.
], 'Course Apps API service'); | ||
|
||
export const getApiBaseUrl = () => getConfig().STUDIO_BASE_URL; | ||
export const getZendeskrUrl = () => `${getApiBaseUrl()}/zendesk_proxy/v0`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can make Zendesk a plugin?
@arbrandes The scope of this work is to match what is already present in |
That is correct. The goal here is to move items out of studio-frontend so it can be deprecated. However, these improvements are worth tracking, likely in an issue against the repo for future work. Thanks! |
In discussion with Axim engineering, the consensus is that since this is a port it's fine for it to go in as is. That said, a few important points were raised:
|
JIRA Ticket: TNL-10754
This PR adds the code for the Accessibility request page. This additional support the DEPR-381.
Testing
SHOW_ACCESSIBILITY_PAGE
in env.dev to true