Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump frontend-platform #159

Conversation

arslanashraf7
Copy link

This is a backport of #158 to quince.master. This should fix PUBLIC_PATH issue in the quince release.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @arslanashraf7! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@arslanashraf7
Copy link
Author

Hey @arbrandes, Just letting you know that I've created a similar backport here as well.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7ce2a61) 83.01% compared to head (202604a) 83.01%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           open-release/quince.master     #159   +/-   ##
===========================================================
  Coverage                       83.01%   83.01%           
===========================================================
  Files                              46       46           
  Lines                             683      683           
  Branches                          132      132           
===========================================================
  Hits                              567      567           
  Misses                            116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Oct 24, 2023
@mphilbrick211
Copy link

Hi @arbrandes! Are you able to review this?

@arbrandes arbrandes merged commit ce1e7d0 into openedx:open-release/quince.master Nov 14, 2023
6 checks passed
@openedx-webhooks
Copy link

@arslanashraf7 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants