-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove extra margin around body element #193
base: master
Are you sure you want to change the base?
fix: Remove extra margin around body element #193
Conversation
Thanks for the pull request, @Lunyachek! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 46 46
Lines 685 685
Branches 132 132
=======================================
Hits 569 569
Misses 116 116 ☔ View full report in Codecov by Sentry. |
Hi @openedx/committers-frontend! This is ready for review, as is the backport. Thanks! |
This issue seems to be bigger than just the margins. When inspecting I found vs I don't think that going through and overriding all the tinymce styles with |
You're definitely right! I looked deeper and found a solution in the MFE discussions - https://github.com/openedx/frontend-app-discussions/blob/master/src/components/TinyMCEEditor.jsx I applied the fix in the same way |
Hi @Lunyachek and @brian-smith-tcril, just checking in on this! |
Friendly follow-up on this @Lunyachek @brian-smith-tcril |
I think this is likely a good solution, but I'd like to get a second opinion on using Context: Since my previous review this PR has been updated to follow the |
@Lunyachek @brian-smith-tcril - is this still in progress? |
This pull request proposes fixing the margin around the body element. This margin comes from the tinyMCE styles. In cases where we don't have a custom theme, and the header and footer are white, it's not noticeable (1st screenshot). However, if the header and footer have any color, it immediately stands out (2nd and 3rd screenshots). The
important
property is set not by chance, as without it, the styles from the tinyMCE override the styles from the index.scss file.