Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: same titles for sent email groups #207

Open
wants to merge 4 commits into
base: open-release/redwood.master
Choose a base branch
from

Conversation

khudym
Copy link

@khudym khudym commented Jul 5, 2024

Description

  • this PR proposes making the display of mail recipients the same for all places (checkbox labels, Send email alert modal, Scheduled emails table with View Modal, Email Task History)

Related Pull Requests
PR to the open-release/quince.master branch: #206
PR to the master branch: #205

Steps to reproduce

click on "Staff/Administrators" checkbox -> complete the form (subject, body) -> options:

  • to see recipients titles in "Caution" modal, click on "Send email" button
  • same if you schedule day and time and click on "Schedule email" button
    (in this modal you can see the difference between recipients titles and selected checkbox label)

-> click "Continue" button -> wait for the "Scheduled emails" table to load and also compare titles in "Send to" column

BEFORE

Example with selected "Staff/Administrators"

Знімок екрана 2023-10-24 о 18 00 15

Знімок екрана 2023-10-24 о 18 00 28

Screenshot 2024-07-03 at 23 57 31

Знімок екрана 2023-10-24 о 18 02 22

Example with selected "All Learners"


Знімок екрана 2023-10-24 о 18 33 10

Знімок екрана 2023-10-24 о 18 32 57

Screenshot 2024-07-04 at 00 28 05

Знімок екрана 2023-10-24 о 18 33 16

AFTER

Screenshot 2024-07-04 at 19 16 46 Screenshot 2024-07-04 at 19 15 34 Screenshot 2024-07-04 at 19 19 17 Screenshot 2024-07-04 at 19 23 00 Screenshot 2024-07-04 at 19 22 31

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 5, 2024

Thanks for the pull request, @khudym!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 5, 2024
@khudym khudym marked this pull request as ready for review July 8, 2024 10:00
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Jul 16, 2024
@mphilbrick211 mphilbrick211 requested a review from a team July 16, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Backlog
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants