-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhancements to page #577
feat: Enhancements to page #577
Conversation
vladislavkeblysh
commented
Oct 12, 2023
- Fixed font family on page
- Fixed borders on action bar on mobile view
- Fixed newest first text overlap another text
- Fixed displaying user name on mobile view
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@vladislavkeblysh Thank you for this contribution! @jmakowski1123 With this set of changes I'm not sure if we need to step through the full product review process. It seems like they are just fixing some small visual inconsistencies. What do you think?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 169 169
Lines 3468 3468
Branches 900 900
=======================================
Hits 3205 3205
Misses 243 243
Partials 20 20 ☔ View full report in Codecov by Sentry. |
@jmakowski1123 Friendly ping about this question -- do you think this PR needs a round of product review? |
@jmakowski1123 @awais-ansari It sounds like product review for this PR has already started (?). If so, could you please point me to where that conversation is happening? It doesn't seem like we have a feature ticket for this PR, so it's hard for me to tell what its current status is. |
97c3023
to
a31ca8d
Compare
cbafd73
to
5cf243c
Compare
@mphilbrick211 Is this PR still in a product review? or is it ready for merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
@awais-ansari We haven't heard back from Product - so please hold off on merging. CC: @jmakowski1123 |
This is approved. |
@vladislavkeblysh Please update this PR. |
@awais-ansari Done, thank you |
All set to merge, @awais-ansari! |
@vladislavkeblysh can you please update this PR one more time? |
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |