Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed UI issues of discussion for incontext sidebar #633

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Dec 27, 2023

INF-1184

Description

fixed UI issues of discussion for incontext sidebar based on Figma Legacy Notifications vs Discussions Sidebar.

Screenshots/sandbox (optional):

Screenshot 2023-12-27 at 2 22 42 PM Screenshot 2023-12-27 at 2 20 37 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5d036a) 92.41% compared to head (385b5d7) 92.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #633   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         169      169           
  Lines        3468     3468           
  Branches      900      900           
=======================================
  Hits         3205     3205           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/discussions/posts/post-actions-bar/PostActionsBar.jsx Outdated Show resolved Hide resolved
src/index.scss Outdated Show resolved Hide resolved
src/discussions/posts/post-actions-bar/PostActionsBar.jsx Outdated Show resolved Hide resolved
src/index.scss Outdated Show resolved Hide resolved
src/discussions/posts/post-actions-bar/PostActionsBar.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ayesha-waris ayesha-waris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@sundasnoreen12 sundasnoreen12 merged commit b467298 into master Jan 2, 2024
7 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1184 branch January 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants