-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed UI issues of discussion for incontext sidebar #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
requested review from
ayesha-waris,
awais-ansari and
muhammadadeeltajamul
and removed request for
ayesha-waris
December 27, 2023 09:27
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 169 169
Lines 3468 3468
Branches 900 900
=======================================
Hits 3205 3205
Misses 243 243
Partials 20 20 ☔ View full report in Codecov by Sentry. |
awais-ansari
suggested changes
Dec 27, 2023
awais-ansari
suggested changes
Dec 28, 2023
awais-ansari
approved these changes
Jan 1, 2024
ayesha-waris
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1184
Description
fixed UI issues of discussion for incontext sidebar based on Figma Legacy Notifications vs Discussions Sidebar.
Screenshots/sandbox (optional):
Merge Checklist
Post-merge Checklist