Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed enable_learners_tab_in_discussions_mfe flag dependency #637

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

ayesha-waris
Copy link
Contributor

INF-1185

Description

Removed discussions.enable_learners_tab_in_discussions_mfe dependency in MFE

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e95458) 92.41% compared to head (2feaa99) 92.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   92.41%   92.38%   -0.04%     
==========================================
  Files         169      169              
  Lines        3468     3452      -16     
  Branches      900      892       -8     
==========================================
- Hits         3205     3189      -16     
  Misses        243      243              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this flag dependency from test files also.
PostLink.test.jsx
PostsView.test.jsx
LearnersView.test.jsx
DiscussionsHome.test.jsx
AuthorLabel.test.jsx

src/discussions/discussions-home/DiscussionSidebar.jsx Outdated Show resolved Hide resolved
src/discussions/discussions-home/DiscussionSidebar.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nits as mentioned by Sundas other than LGTM.

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM.
please rebase the PR with master

@ayesha-waris ayesha-waris merged commit ee61d1c into master Jan 5, 2024
6 of 7 checks passed
@ayesha-waris ayesha-waris deleted the Ayesha/INF-1185 branch January 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants