Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented error handling mockup #663

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Conversation

sundasnoreen12
Copy link
Contributor

INF-1100

Description

When a user navigates to a discussion board or a discussion post, they see an empty screen with indefinite loading in the following case:

  1. They are not enrolled in the course

Acceptance Criteria

We need to show a meaningful message to users instead of indefinite loading.
Figma

Screenshots/sandbox (optional):

Screenshot 2024-02-12 at 6 46 27 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@sundasnoreen12 sundasnoreen12 changed the title draft: implemented error handling mockup feat: implemented error handling mockup Feb 12, 2024
@sundasnoreen12 sundasnoreen12 marked this pull request as draft February 12, 2024 14:06
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f0a4586) 92.76% compared to head (8aa935f) 92.81%.

Files Patch % Lines
...c/discussions/discussions-home/DiscussionsHome.jsx 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   92.76%   92.81%   +0.05%     
==========================================
  Files         156      158       +2     
  Lines        3303     3326      +23     
  Branches      905      915      +10     
==========================================
+ Hits         3064     3087      +23     
  Misses        219      219              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to remove unnecessary indentation changes.

src/discussions/messages.js Show resolved Hide resolved
src/discussions/discussions-home/DiscussionsHome.jsx Outdated Show resolved Hide resolved
src/discussions/discussions-home/DiscussionsHome.jsx Outdated Show resolved Hide resolved
@awais-ansari awais-ansari marked this pull request as ready for review February 16, 2024 07:56
@sundasnoreen12 sundasnoreen12 merged commit ac17fd7 into master Feb 21, 2024
7 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1100 branch February 21, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants