Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block overflow when editing comment #710

Conversation

ihor-romaniuk
Copy link
Contributor

Description

This merge request contains a fix for the comment edit block width at small screen resolutions for course Discussions pages or discussion sidebar in MFE Learning.

Related PR

Screenshots:

Before After
image image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 3, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ihor-romaniuk ihor-romaniuk added backport PR backports a change from main to a named release. and removed open-source-contribution PR author is not from Axim or 2U labels Jun 3, 2024
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 3, 2024
@ayesha-waris ayesha-waris requested review from awais-ansari, sundasnoreen12 and ayesha-waris and removed request for ayesha-waris June 11, 2024 09:32
@ayesha-waris ayesha-waris merged commit 1451423 into openedx:open-release/redwood.master Jun 11, 2024
5 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bra-i-am pushed a commit to eduNEXT/frontend-app-discussions that referenced this pull request Jul 23, 2024
bra-i-am added a commit to eduNEXT/frontend-app-discussions that referenced this pull request Jul 29, 2024
* feat: import `FooterSlot` from `frontend-slot-footer` package

* fix: block overflow when editing comment (openedx#710)

* fix: fixed author liking its own post (openedx#729)

* perf: update redwood branch with upstream

* refactor: generate package-lock with conflicts solved

* fix: tests failed because axios and react-markdown lib errors

---------

Co-authored-by: Brian Smith <[email protected]>
Co-authored-by: Ihor Romaniuk <[email protected]>
Co-authored-by: ayesha waris <[email protected]>
@ihor-romaniuk ihor-romaniuk deleted the romaniuk/fix/edit-comment-block-width-redwood branch February 3, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants