Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add max value warning and disable the submit button #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farhaanbukhsh
Copy link
Member

@farhaanbukhsh farhaanbukhsh commented Jan 12, 2025

Based on: #402

~~Discussions: ~~

Dependencies: None

Screenshots: Always include screenshots if there is any change to the UI.

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

  1. Mount the grade book repo in Tutor make sure Tutor is not running at this moment, tutor mounts add <repo-for-gradebook>

  2. Rebuild the image tutor image build openedx-dev

  3. tutor dev start -d

  4. Import demo course tutor dev do importdemocourse

  5. Make a learner account, enroll in the course and take a bunch of quiz, assignments

  6. Log out and sign in from a super user account.

  7. Under the Demo course, get into the "Student Admin" tab

  8. There is "View gradebook for enrolled learners" section

  9. Click on "View Gradebook"

  10. new_selection

  11. You will see something like above

  12. Click on marks and you should be able to give marks beyond 100% ie. something like 50/20

  13. In Gradebook repo change to the PR branch

  14. Restart gradebok tutor dev restart gradebook

  15. Repeat Step 12 you will see an error and the input will be disabled.

@farhaanbukhsh farhaanbukhsh requested a review from a team as a code owner January 12, 2025 06:37
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 12, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 12, 2025

Thanks for the pull request, @farhaanbukhsh!

This repository is currently maintained by @farhaanbukhsh.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (e458d6f) to head (b063153).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   94.98%   94.99%   +0.01%     
==========================================
  Files         139      139              
  Lines        1356     1359       +3     
  Branches      265      265              
==========================================
+ Hits         1288     1291       +3     
  Misses         60       60              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: lkatsikaris <lkatsikaris@@users.noreply.github.com>

Signed-off-by: Farhaan Bukhsh <[email protected]>
@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/max-adjusted-grade-warning branch from ca61729 to b063153 Compare January 12, 2025 14:20
@farhaanbukhsh
Copy link
Member Author

@bradenmacdonald @arbrandes Can you folks review this PR, please 😇

@bradenmacdonald
Copy link

@farhaanbukhsh Can you please provide test instructions, or get another reviewer to confirm that this is working? I don't even know how to access the gradebook, but am happy to help review if you provide the instructions (or a sandbox).

@farhaanbukhsh
Copy link
Member Author

@farhaanbukhsh Can you please provide test instructions, or get another reviewer to confirm that this is working? I don't even know how to access the gradebook, but am happy to help review if you provide the instructions (or a sandbox).

Thanks a lot @bradenmacdonald

I don't have anyone but you and Adolfo to review the PRs so I'm sorry for troubling you. But it will really help to keep the repo up to date :)

@bradenmacdonald
Copy link

Click on marks and you should be able to give marks beyond 100% ie. something like 50/20

Are we sure this should be disallowed? My professors in University used to regularly give "bonus marks" and people sometimes got grades like 105% on various quizzes/exams.

Copy link

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just had a product question ^ to confirm that we actually want to prevent this.

I tested and it's working as expected:
Screenshot

name="adjustedGradeValue"
value={value}
onChange={onChange}
/>
{hintText}
{value > possibleGrade ? <div style={{ color: 'red' }}>{ formatMessage(messages.adjustedGradeError, { possibleGrade })}</div> : hintText}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It's generally preferred to use the <FormattedMessage /> component rather than calling formatMessage directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants