-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add max value warning and disable the submit button #426
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 94.98% 94.99% +0.01%
==========================================
Files 139 139
Lines 1356 1359 +3
Branches 265 265
==========================================
+ Hits 1288 1291 +3
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: lkatsikaris <lkatsikaris@@users.noreply.github.com> Signed-off-by: Farhaan Bukhsh <[email protected]>
ca61729
to
b063153
Compare
@bradenmacdonald @arbrandes Can you folks review this PR, please 😇 |
@farhaanbukhsh Can you please provide test instructions, or get another reviewer to confirm that this is working? I don't even know how to access the gradebook, but am happy to help review if you provide the instructions (or a sandbox). |
Thanks a lot @bradenmacdonald I don't have anyone but you and Adolfo to review the PRs so I'm sorry for troubling you. But it will really help to keep the repo up to date :) |
Are we sure this should be disallowed? My professors in University used to regularly give "bonus marks" and people sometimes got grades like 105% on various quizzes/exams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name="adjustedGradeValue" | ||
value={value} | ||
onChange={onChange} | ||
/> | ||
{hintText} | ||
{value > possibleGrade ? <div style={{ color: 'red' }}>{ formatMessage(messages.adjustedGradeError, { possibleGrade })}</div> : hintText} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It's generally preferred to use the <FormattedMessage />
component rather than calling formatMessage
directly.
Based on: #402
~~Discussions: ~~
Dependencies: NoneScreenshots: Always include screenshots if there is any change to the UI.Sandbox URL: TBD - sandbox is being provisioned.Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.Testing instructions:
Mount the grade book repo in Tutor make sure Tutor is not running at this moment,
tutor mounts add <repo-for-gradebook>
Rebuild the image
tutor image build openedx-dev
tutor dev start -d
Import demo course
tutor dev do importdemocourse
Make a learner account, enroll in the course and take a bunch of quiz, assignments
Log out and sign in from a super user account.
Under the Demo course, get into the "Student Admin" tab
There is "View gradebook for enrolled learners" section
Click on "View Gradebook"
You will see something like above
Click on marks and you should be able to give marks beyond 100% ie. something like 50/20
In Gradebook repo change to the PR branch
Restart gradebok
tutor dev restart gradebook
Repeat Step 12 you will see an error and the input will be disabled.