fix: URLs get the current value of LMS_BASE_URL from getConfig() #269

[hinakhadim]

Unenroll URL was picking the stale value of getConfig().LMS_BASE_URL. After the following changes, it'll pick the current value of getConfig().LMS_BASE_URL. This is done on the basis of openedx/frontend-platform. This PR will fix the #269 .

[openedx-webhooks]

Thanks for the pull request, @hinakhadim! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

[itsjeyd]

Hey @hinakhadim, thank you for this contribution!

As the bot says, the next step will be for you to submit a signed CLA. Once that's done and the build is green, we can line this PR up for engineering review.

[hinakhadim]

Signing of CLA has been done.

[itsjeyd]

@hinakhadim Great! I'm lining the changes up for a test run.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a2d6db) 96.04% compared to head (c73c0fe) 96.04%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         194      194           
  Lines        1844     1844           
  Branches      322      322           
=======================================
  Hits         1771     1771           
  Misses         68       68           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mariajgrimaldi]

Thank you! This change will also fix openedx/wg-build-test-release#336, so we'll need to backport it to quince once it's merged here. I tested the unenroll changes locally in my Tutor nightly environment, and now it's working as expected. Thank you again!

[arbrandes]

Looks great, thanks!

[jsnwesson]

Works on my devstack as well, thanks for pinging me @arbrandes !

[arbrandes]

@hinakhadim, do you mind rebasing and resolving conflicts, so we can merge your PR?

[hinakhadim]

Thanks everyone for your attention. I've rebased the PR, feel free to have a look on it.

[mariajgrimaldi]

I went ahead and created the backport for Quince. Once this is merged, we can review/merge that one. Thanks!