-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: translation for header of course filter form (course status) #289
fix: translation for header of course filter form (course status) #289
Conversation
Thanks for the pull request, @FatemeKhodayari! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @FatemeKhodayari, thank you for this contribution! I'm lining the changes up for a test run. |
CC @e0d ⬆️ When you get a minute could you kick off a build for this PR, please? |
I approved the test run, @FatemeKhodayari -- could you take a look at the linting/quality errors in your contribution? Thanks! |
Oops! Sorry for the errors! Fixed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this up! Once the tests pass again, I'll merge this change. :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 96.18% 96.19%
=======================================
Files 184 184
Lines 1732 1734 +2
Branches 309 309
=======================================
+ Hits 1666 1668 +2
Misses 61 61
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
The expression "Course Status" used as the header of course filter form was hard coded so it wouldn't get translated according to the user's language.
Closes #288