Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translation for header of course filter form (course status) #289

Merged

Conversation

FatemeKhodayari
Copy link
Contributor

The expression "Course Status" used as the header of course filter form was hard coded so it wouldn't get translated according to the user's language.

Closes #288

@FatemeKhodayari FatemeKhodayari requested a review from a team as a code owner February 10, 2024 17:10
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 10, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @FatemeKhodayari! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd
Copy link

itsjeyd commented Feb 16, 2024

Hi @FatemeKhodayari, thank you for this contribution! I'm lining the changes up for a test run.

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 16, 2024
@itsjeyd
Copy link

itsjeyd commented Feb 22, 2024

CC @e0d ⬆️

When you get a minute could you kick off a build for this PR, please?

@justinhynes
Copy link
Contributor

I approved the test run, @FatemeKhodayari -- could you take a look at the linting/quality errors in your contribution?

Thanks!

@FatemeKhodayari
Copy link
Contributor Author

FatemeKhodayari commented Feb 24, 2024

I approved the test run, @FatemeKhodayari -- could you take a look at the linting/quality errors in your contribution?

Thanks!

Oops! Sorry for the errors! Fixed them.

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up! Once the tests pass again, I'll merge this change. :)

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (99815e8) to head (c839810).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   96.18%   96.19%           
=======================================
  Files         184      184           
  Lines        1732     1734    +2     
  Branches      309      309           
=======================================
+ Hits         1666     1668    +2     
  Misses         61       61           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinhynes justinhynes merged commit e8660b9 into openedx:master Feb 26, 2024
6 checks passed
@openedx-webhooks
Copy link

@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@FatemeKhodayari FatemeKhodayari deleted the fix/course-status-translation branch February 27, 2024 06:26
@itsjeyd itsjeyd removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Filter Form header (Course Status) is not marked for translation
4 participants