-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if support page is not set, help button does not appears in header UPDATED #478
Conversation
Thanks for the pull request, @lkatsikaris! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hey @lkatsikaris 👋 Unfortunately, your branch is out of date with master. You'll need to pull the latest changes from master and then start a new branch from there. For example, if you look at the current directory structure of LearnerDashboardHeader in master, it's slightly different than what you have on your branch. As a result, the code you are modifying actually no longer exists on the master branch. It's also worth mentioning that someone else has also submitted a PR to fix this: #469. Perhaps we can consolidate efforts into one PR? |
Hi @MaxFrank13, thanks for the response! If that PR is about to be approved, we can continue with it! |
Hi @lkatsikaris and @MaxFrank13, it sounds like we can close this PR? I'll do that now but please reopen if I missed something. Thanks! |
Duplicate of #469. |
Fix: if the support page is not set, the help button does not appear in the header
Fixes #373
What changed?
Developer Checklist
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR: