-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Zendesk component from Learner Dashboard (fixes #519) #532
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @paulbert! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 97.40% 97.39% -0.01%
==========================================
Files 157 155 -2
Lines 1389 1384 -5
Branches 231 232 +1
==========================================
- Hits 1353 1348 -5
Misses 34 34
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Hey @paulbert , thanks for picking this up! I forgot to add the environment variable, but that should also be removed in this work, thanks! For the Jest snapshots, I realize now that the only snapshots that existed for this component were in the Once you've got the PR up-to-date with the main branch and the env variable is removed, my team should be able to review this PR next week! |
dfb14a7
to
9dba5e4
Compare
@jsnwesson Updated to the main branch last night and removed the env variables. I squashed the commits and rewrote the message since I didn’t follow the commit message guidelines the first time. Let me know if a different commit type than refactor would be more appropriate. Thanks! |
@jsnwesson when you do sign off on this one, I'm pretty sure that failing codecov test is just because the removed code and tests change the code:test ratio in the repository, so the percentage report thinks we have a lower code coverage ratio; this is just removals and there's no actual missing tests. |
Thanks @paulbert ! I use OEP-51 as a reference for my commits, and so I think Once you change the commit message, I'll merge it to main :D |
Deletes the ZendeskFab component and associated mock, removes react-zendesk package, and removes env variables for Zendesk
9dba5e4
to
c697256
Compare
@jsnwesson Thanks! Updated the commit message and rebased it to be up to date. |
react-zendesk
packageI'm not sure about the "Update Jest snapshot" part but I ran the tests locally and they all passed.
Also there are references to a
ZENDESK_KEY
environment variable that don't seem to be used anywhere. Should I remove that in this PR?Issue references:
Fixes #519 #496 #225