Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test against node 18 in CI #396

Merged
merged 2 commits into from
Aug 22, 2024
+4 −4
Merged

chore: test against node 18 in CI #396

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b7332f
chore: test against node 18 in CI
MaxFrank13 Aug 21, 2024
a52b84d
fix: remove line
MaxFrank13 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,19 @@ on: [push, pull_request]
jobs:
tests:
runs-on: ubuntu-latest

strategy:
matrix:
node: [18, 20]
coninue-on-error: ${{ matrix.node == 20 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
coninue-on-error: ${{ matrix.node == 20 }}

Since 2nd step to upgrade to v20 was already cleared before this, we need to remove continue-on-error in order to make the Node 20 test a blocking one.

steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
- name: Setup Nodejs
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VER }}
node-version: ${{ matrix.node }}
- name: Install dependencies
run: npm ci
- name: Validate package-lock.json changes
Expand Down