Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix discussions and notifications sidebars visibility with big amount of units #1333

Conversation

Lunyachek
Copy link
Contributor

Description

When we have too many units in a section, the course content significantly compresses the sidebar with Discussions and Notifications. It becomes impossible to interact with them. Our proposal is to add horizontal scrolling to the unit navigation if there are too many units. To be more precise, horizontal scrolling for unit navigation is already provided, but it does not work because the sidebar with Discussions and Notifications simply compresses.

Demo

Before fix

2024-03-25.18.07.56.mov

After fix

2024-03-25.18.35.17.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 25, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (0cb369a) to head (bac7eec).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1333   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         293      293           
  Lines        4988     4988           
  Branches     1266     1266           
=======================================
  Hits         4401     4401           
  Misses        571      571           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmakowski1123
Copy link

See comment here: openedx/platform-roadmap#348

@itsjeyd
Copy link

itsjeyd commented Apr 26, 2024

@Lunyachek I'm closing this PR based on this update about sidebar enhancements from product.

Feel free to reopen it and resume the conversation via openedx/platform-roadmap#348 once you've had a chance to test the sidebar enhancements in Redwood.

CC @jmakowski1123

@itsjeyd itsjeyd closed this Apr 26, 2024
@openedx-webhooks
Copy link

@Lunyachek Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by other work PR cannot be finished until other work is complete open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants