Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #1443

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Aug 15, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (dc1e9cd) to head (d1e89ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1443   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files         310      310           
  Lines        5319     5319           
  Branches     1315     1349   +34     
=======================================
  Hits         4669     4669           
  Misses        633      633           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:44
@BilalQamar95
Copy link
Contributor Author

PR will be updated and ready for review once the prerequisite PR for first step of the node v20 upgrade process is merged.

@BilalQamar95 BilalQamar95 mentioned this pull request Aug 23, 2024
@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Aug 23, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review September 4, 2024 11:56
@brian-smith-tcril brian-smith-tcril merged commit ec8b5c5 into master Sep 6, 2024
7 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node-v20-upgrade branch September 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants