-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: xblock error mfe unit preview #1508
fix: xblock error mfe unit preview #1508
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
- Coverage 89.24% 89.23% -0.01%
==========================================
Files 316 317 +1
Lines 5549 5557 +8
Branches 1369 1341 -28
==========================================
+ Hits 4952 4959 +7
- Misses 581 583 +2
+ Partials 16 15 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: option to show/hide ungraded assignment in progress page test: add tests for show ungraded toggle feat: update score label in progress page based on grading refactor: update score label text and add tooltip refactor: move label tooltip near header as normal text refactor: update problem score label Graded scores * refactor: move config check to utils
* test: Remove support for Node 18 * chore: update code coverage artifact naming
Description
This PR fixes xblock not showing the preview when a course staff member is masquerading as another user/course track. Additionally this PR fixes navigation between units that have never been published and units that have been published with or without edits.
Testing
Testing view for different course tracks
Repeat steps above when masquerading as a verified learner and audit learner. Confirm that the preview is displayed as expected for each track.
Testing for unit navigation
Other information
This PR is dependent on
edx-platform
PR #35747