Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #312

Merged
merged 1 commit into from
Feb 5, 2024
Merged

feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #312

merged 1 commit into from
Feb 5, 2024

Conversation

OmarIthawi
Copy link
Member

Similar to openedx/frontend-app-communications#187.

Changes

  • install atlas
  • remove --filter to pull all languages by default
  • use ATLAS_OPTIONS to allow custom --filter
  • include frontend-platform in atlas pull

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 1, 2024
@OmarIthawi OmarIthawi mentioned this pull request Feb 1, 2024
Merged
14 tasks
@brian-smith-tcril
Copy link
Contributor

@OmarIthawi this should pass CI if you rebase now that #311 has been merged.

@OmarIthawi
Copy link
Member Author

Thanks for the heads up @brian-smith-tcril. Done!

@codecov Codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f135f9a) 100.00% compared to head (e0ac954) 100.00%.

❗ Current head e0ac954 differs from pull request most recent head 948036a. Consider uploading reports for the commit 948036a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1079      1079           
  Branches       159       159           
=========================================
  Hits          1079      1079

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril
Copy link
Contributor

@OmarIthawi it looks like this needs another quick rebase. I'll merge as soon as it's rebased.

@OmarIthawi
feat: tutor-mfe compatiblilty for atlas pull
948036a 
 - install atlas
 - remove `--filter` to pull all languages by default
 - use ATLAS_OPTIONS to allow custom `--filter`
 - include frontend-platform in `atlas pull`
@OmarIthawi
Copy link
Member Author

OmarIthawi commented Feb 5, 2024 •
edited
Loading

Sure @brian-smith-tcril. Rebase's done.

@brian-smith-tcril brian-smith-tcril merged commit 4a708da into openedx:master Feb 5, 2024
4 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmarIthawi @openedx-webhooks @brian-smith-tcril