Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Profile Plugin Page #868

Merged
merged 12 commits into from
Oct 13, 2023
Merged

Conversation

jsnwesson
Copy link
Contributor

This PR directly inserts the Frontend Plugin Framework that originally lived in Frontend Platform.

This also includes:

  • a Profile page that will be used as a Plugin

@jsnwesson jsnwesson force-pushed the jwesson/plugin-profile-page branch from f21a400 to 6cedecc Compare October 13, 2023 05:22
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (ProfilePluginPOC@e73b646). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             ProfilePluginPOC     #868   +/-   ##
===================================================
  Coverage                    ?   62.78%           
===================================================
  Files                       ?       53           
  Lines                       ?      868           
  Branches                    ?      161           
===================================================
  Hits                        ?      545           
  Misses                      ?      313           
  Partials                    ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/index.jsx Outdated Show resolved Hide resolved
Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One nit pick but not blocking

@jsnwesson jsnwesson merged commit 9291ea6 into ProfilePluginPOC Oct 13, 2023
8 checks passed
@jsnwesson jsnwesson deleted the jwesson/plugin-profile-page branch October 13, 2023 17:50
@jsnwesson jsnwesson restored the jwesson/plugin-profile-page branch October 13, 2023 18:17
@jsnwesson jsnwesson deleted the jwesson/plugin-profile-page branch October 13, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants