Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix config name from MARKETING_BASE_URL to MARKETING_SITE_BASE_URL #381

Merged

Conversation

asadali145
Copy link
Contributor

Description:
The config name for the marketing URL is MARKETING_SITE_BASE_URL but MARKETING_BASE_URL is used in the Footer and it is not getting picked up from the config. This PR just fixes the name of the config variable.

@openedx-webhooks
Copy link

Thanks for the pull request, @asadali145! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed5aeb8) 89.09% compared to head (a5ca665) 89.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files           6        6           
  Lines          55       55           
  Branches       18       18           
=======================================
  Hits           49       49           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdullahwaheed abdullahwaheed merged commit 5059e0d into openedx:master Dec 22, 2023
7 checks passed
@openedx-webhooks
Copy link

@asadali145 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants