Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use single plugin slot #24

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

MaxFrank13
Copy link
Member

This work is to finish integrating Direct Plugins with the rest of the plugin framework. A single configuration can now handle both types of plugins that are currently offered (i.e. IFRAME_PLUGIN, DIRECT_PLUGIN)

Some of the new additions:

  • PluginContainerDirect that utilizes the plugin's configuration
  • Helper function added to wrap plugins
  • New plugin shapes to be used in each type of plugin
  • The DirectPlugins directory has been removed as it's contents were moved or no longer being used
  • Tests to verify the above 🤞

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1033187) 72.61% compared to head (b0085ad) 90.05%.
Report is 2 commits behind head on master.

❗ Current head b0085ad differs from pull request most recent head 298af7b. Consider uploading reports for the commit 298af7b to get more accurate results

Files Patch % Lines
src/plugins/PluginSlot.jsx 93.33% 1 Missing ⚠️
src/plugins/data/hooks.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #24       +/-   ##
===========================================
+ Coverage   72.61%   90.05%   +17.43%     
===========================================
  Files          13       12        -1     
  Lines         168      171        +3     
  Branches       30       32        +2     
===========================================
+ Hits          122      154       +32     
+ Misses         44       15       -29     
  Partials        2        2               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.rst Show resolved Hide resolved
@MaxFrank13 MaxFrank13 force-pushed the mfrank/single-plugin-slot branch from b0085ad to 298af7b Compare February 2, 2024 19:43
@MaxFrank13 MaxFrank13 merged commit 1a239eb into master Feb 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants