Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example apps #33

Merged
merged 25 commits into from
Mar 4, 2024
Merged

feat: add example apps #33

merged 25 commits into from
Mar 4, 2024

Conversation

jsnwesson
Copy link
Contributor

@jsnwesson jsnwesson commented Feb 29, 2024

APER-3042

This PR includes:

  • example apps that display the use of direct and iFrame plugins
  • examples of using all four Plugin Operations (Insert, Modify, Wrap, Hide)
  • a bug fix when using getConfig in usePluginSlot
  • update how Plugin and PluginSlot retrieve intl using useIntl function from frontend platform

Steps to run example apps

Run npm install in the root directory, then

Using two terminals:

  1. Run npm install inside both example app directories.
  2. Run npm run start in both directories.

Alternatively, once the packages are installed in both apps, you can run the apps from the root directory.
1.npm run start runs the host MFE (example)
2. npm run start:plugins runs the child MFE (example-plugin-app)

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.57%. Comparing base (3d73607) to head (e70b31a).

Files Patch % Lines
src/plugins/data/hooks.js 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   90.80%   94.57%   +3.77%     
==========================================
  Files          12       10       -2     
  Lines         174      166       -8     
  Branches       32       32              
==========================================
- Hits          158      157       -1     
+ Misses         14        7       -7     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.rst Outdated Show resolved Hide resolved
example/package.json Outdated Show resolved Hide resolved
example/package.json Outdated Show resolved Hide resolved
@jsnwesson jsnwesson merged commit 4c8b4f1 into master Mar 4, 2024
5 of 7 checks passed
@jsnwesson jsnwesson deleted the jwesson/create-example-apps branch March 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants