generated from openedx/frontend-template-application
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add example apps #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 90.80% 94.57% +3.77%
==========================================
Files 12 10 -2
Lines 174 166 -8
Branches 32 32
==========================================
- Hits 158 157 -1
+ Misses 14 7 -7
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This reverts commit 3efb5e8.
* fix lint in example apps
justinhynes
reviewed
Mar 1, 2024
justinhynes
reviewed
Mar 1, 2024
justinhynes
reviewed
Mar 1, 2024
justinhynes
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
reviewed
Mar 1, 2024
MaxFrank13
approved these changes
Mar 1, 2024
justinhynes
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APER-3042
This PR includes:
getConfig
in usePluginSlotintl
usinguseIntl
function fromfrontend platform
Steps to run example apps
Run
npm install
in the root directory, thenUsing two terminals:
npm install
inside both example app directories.npm run start
in both directories.Alternatively, once the packages are installed in both apps, you can run the apps from the root directory.
1.
npm run start
runs the host MFE (example)2.
npm run start:plugins
runs the child MFE (example-plugin-app)