Skip to content

Commit

Permalink
build: Upgrade to Node 20
Browse files Browse the repository at this point in the history
Add official Node 20 support by:

* Upgrading to Node 20 in `.nvmrc`
* Regenerating `package-lock.json` from scratch using it
* Blocking on Node 20 CI failures
* Updating lockfile check workflow to v3
  • Loading branch information
arbrandes committed Mar 8, 2024
1 parent b0fe48d commit b6963be
Show file tree
Hide file tree
Showing 4 changed files with 417 additions and 364 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ jobs:
strategy:
matrix:
node: [18, 20]
continue-on-error: ${{ matrix.node == 20 }}

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lockfileversion-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ on:

jobs:
version-check:
uses: openedx/.github/.github/workflows/lockfile-check.yml@master
uses: openedx/.github/.github/workflows/lockfile-check-v3.yml@master
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
Loading

0 comments on commit b6963be

Please sign in to comment.