Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: renewal processing saves original activation keys #705

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: renewal processing saves original activation keys #705

merged 1 commit into from
Sep 5, 2024

Conversation

iloveagent57
Copy link
Contributor

We previously were assigning, but not saving, the activation key from original to future licenses when processing renewals.
ENT-9276

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@iloveagent57
fix: renewal processing saves original activation keys
63aceb8 
We previously were assigning, but not _saving_, the activation key
from original to future licenses when processing renewals.
ENT-9276
adamstankiewicz
adamstankiewicz approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@iloveagent57 iloveagent57 merged commit 5afa00b into master Sep 5, 2024
5 checks passed
@iloveagent57 iloveagent57 deleted the aed/fix-renewal-act-key branch September 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iloveagent57 @adamstankiewicz