fix: Update resume course navigation #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerhabib26
requested review from
volodymyr-chekyrta,
HamzaIsrar12 and
k1rill
HamzaIsrar12
requested changes
Dec 11, 2023
Comment on lines
29
to
34
| fun List<Block>.getVerticalBlocks(): List<Block> { | ||
| return this.filter { it.type == BlockType.VERTICAL } | ||
| } | ||
|
|
||
| fun List<Block>.getSequentialBlocks(): List<Block> { | ||
| return this.filter { it.type == BlockType.SEQUENTIAL } |
There was a problem hiding this comment.
Maybe move it to ListExt.
| val currentBlockIndex = viewModel.getUnitBlocks().indexOfFirst { | ||
| viewModel.getCurrentBlock().id == it.id | ||
| } | ||
| if (currentBlockIndex != -1) { | ||
| binding.viewPager.currentItem = currentBlockIndex | ||
| } | ||
| } | ||
| if (componentId.isEmpty().not()) { | ||
| Handler(Looper.getMainLooper()).post { |
There was a problem hiding this comment.
Please use Coroutines instead.
HamzaIsrar12
approved these changes
Dec 11, 2023
omerhabib26
force-pushed
the
omer/LEARNER-9703
branch
from
0b7d556 to
4c6987f
Compare
- Update navigation for resume component - Code improvement & optimisation fix: LEARNER-9703
k1rill
previously approved these changes
Dec 12, 2023
| ) { | ||
| replaceFragmentWithBackStack( | ||
| fm, | ||
| CourseSectionFragment.newInstance(courseId, blockId, mode, descendantId) | ||
| CourseSectionFragment.newInstance(courseId, subSectionId, mode, unitId, componentId) |
There was a problem hiding this comment.
Can you please use named arguments here, because there are a lot of arguments with the same type here:
CourseSectionFragment.newInstance(
courseId = courseId,
subSectionId = subSectionId,
mode = mode,
unitId = unitId,
componentId = componentId,
)
There was a problem hiding this comment.
updated for the all the methods
| mode: CourseViewMode, | ||
| descendantId: String? = "" | ||
| subSectionId: String, | ||
| unitId: String? = "", |
There was a problem hiding this comment.
Not very clear why there is nullable argument with the default empty string value.
There was a problem hiding this comment.
removed nullable
k1rill
approved these changes
Dec 12, 2023
volodymyr-chekyrta
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
subSectionscreen.Prev_resume_course.mp4
Resume_course.mp4