Course navigation functionality #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixidroid
force-pushed
the
feature/course_navigation
branch
from
34de9cb to
e0305d3
Compare
This was
linked to
issues
Dec 14, 2023
miankhalid
requested review from
farhan-arshad-dev and
HamzaIsrar12
and removed request for
volodymyr-chekyrta
|
Hey @dixidroid, I completed the initial manual review last week and everything was working fine but just noticed these two issues:
And I will share the Code Review points by day end today. 👍🏻 |
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineViewModel.kt
Outdated
Show resolved
Hide resolved
|
Hi @HamzaIsrar12 About the Resume button - we have a ticket for it #127 but it's already assigned to @moiz994 Thanks! |
HamzaIsrar12
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Hi @dixidroid, I have posted the review for the Section and SubSection layer. Hopefully, I will post the review for the Unit and Component level tomorrow.
Great work overall. ✨
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesFragment.kt
Show resolved
Hide resolved
discussion/src/main/java/org/openedx/discussion/presentation/topics/DiscussionTopicsFragment.kt
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesFragment.kt
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/handouts/HandoutsFragment.kt
Show resolved
Hide resolved
discussion/src/main/java/org/openedx/discussion/presentation/topics/DiscussionTopicsFragment.kt
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineFragment.kt
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineUIState.kt
Outdated
Show resolved
Hide resolved
…tedContent field as non null
dixidroid
force-pushed
the
feature/course_navigation
branch
from
f3bd988 to
9b9116b
Compare
HamzaIsrar12
requested changes
Dec 20, 2023
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerViewModel.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerViewModel.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerViewModel.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerViewModel.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerViewModel.kt
Outdated
Show resolved
Hide resolved
dixidroid
force-pushed
the
feature/course_navigation
branch
from
ebdd126 to
a0fc823
Compare
HamzaIsrar12
requested changes
Dec 22, 2023
…he name of the current xBlock
HamzaIsrar12
approved these changes
Dec 22, 2023
volodymyr-chekyrta
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COURSE_NESTED_LIST_ENABLED feature flag has been added to enable this functionality (false by default)
Screen_Recording_20231214_153752_OpenEdX.mp4
COURSE_BANNER_ENABLED feature flag has been added to hide the top banner (visible by default)
COURSE_TOP_TAB_BAR_ENABLED feature flag has been added to enable this functionality (false by default)
Screen_Recording_20231214_153907_OpenEdX.mp4
COURSE_UNIT_PROGRESS_ENABLED feature flag has been added to turn this functionality (false by default)
Screen_Recording_20231214_153946_OpenEdX.mp4