Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Segment SDK implementation and destinations #227

Merged
merged 6 commits into from
Feb 14, 2024
Merged

feat: Segment SDK implementation and destinations #227

merged 6 commits into from
Feb 14, 2024

Conversation

farhan-arshad-dev
Copy link
Contributor

Description

  • Implementation of the Segment SDK to enable integration with the new app.
  • Make sure we make the right initial setup so that the mechanism matches the current production apps.
  • Make the correct connections with other party tools that the segment is feeding the data to:
    • Braze
    • Firebase
    • Google Analytics (Not included, cuz doc)

Doc Ref:

@farhan-arshad-dev
feat: Integration Segment kotlin SDK
ea81a01 
- Fetch segment required key from config
- Create Analytics Manager for segment

doc: https://segment.com/docs/connections/sources/catalog/libraries/mobile/kotlin-android/

fixes: LEARNER-9827
@farhan-arshad-dev
refactor: replace bundle with map for analytics manager
5b034e5 
fixes: LEARNER-9827
@farhan-arshad-dev
feat: Add Firebase destination to make connection with segment
e95dc70 
- If firebase config Analytics source is segment add Firebase as destination in segment

doc: https://segment.com/docs/connections/sources/catalog/libraries/mobile/kotlin-android/destination-plugins/firebase-kotlin-android/

fixes: LEARNER-9827
@farhan-arshad-dev
feat: Add Braze destination to make connection with segment
046fec0 
- If firebase config Analytics source is segment and Braze is enabled than add Braze as destination in segment.

doc: https://github.com/braze-inc/braze-segment-kotlin

fixes: LEARNER-9827
@farhan-arshad-dev farhan-arshad-dev linked an issue Feb 9, 2024 that may be closed by this pull request
[Android] Segment SDK Implementation #218
Closed
omerhabib26
omerhabib26 requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add default dict for Analytics

core/build.gradle Outdated Show resolved Hide resolved
k1rill
k1rill reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code, just a very minor favor

app/src/main/java/org/openedx/app/analytics/FirebaseAnalytics.kt Outdated Show resolved Hide resolved
k1rill
k1rill approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side

HamzaIsrar12
HamzaIsrar12 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️

@farhan-arshad-dev farhan-arshad-dev merged commit f4731df into openedx:develop Feb 14, 2024
3 checks passed
@farhan-arshad-dev farhan-arshad-dev deleted the farhan_ar/LEARNER-9827 branch February 14, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

@omerhabib26 omerhabib26 omerhabib26 approved these changes

@k1rill k1rill k1rill approved these changes

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Segment SDK Implementation
5 participants
@farhan-arshad-dev @k1rill @omerhabib26 @HamzaIsrar12 @volodymyr-chekyrta