Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Branch SDK Integration #239

Merged
merged 3 commits into from
Feb 28, 2024
Merged

feat: Branch SDK Integration #239

merged 3 commits into from
Feb 28, 2024

Conversation

HamzaIsrar12
Copy link
Contributor

This PR adds the integration of the Branch SDK. The Branch SDK will be used for deep links.

Config

BRANCH:
    ENABLED: false
    KEY: ''
    URI_SCHEME: ''
    HOST: ''
    ALTERNATE_HOST: ''

Reference

@HamzaIsrar12
feat: Branch SDK Integration
047f404 
Fixes: LEARNER-9787
k1rill
k1rill reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But one favour, we are still using default_config, can you please add empty branch config fields as an example in current config.yaml files

app/src/main/java/org/openedx/app/AppActivity.kt Outdated Show resolved Hide resolved
k1rill
k1rill previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

omerhabib26
omerhabib26 previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits

app/src/main/java/org/openedx/app/OpenEdXApp.kt Show resolved Hide resolved
app/build.gradle Show resolved Hide resolved
@HamzaIsrar12
refactor: Optimize imports
9e41c51 
Fixes: LEARNER-9787
@HamzaIsrar12 HamzaIsrar12 dismissed stale reviews from omerhabib26 and k1rill via 9e41c51 February 28, 2024 10:35
@HamzaIsrar12 HamzaIsrar12 merged commit 3d08d45 into openedx:develop Feb 28, 2024
3 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-9787 branch February 28, 2024 10:54
volodymyr-chekyrta
volodymyr-chekyrta reviewed Feb 28, 2024
View reviewed changes
app/src/main/AndroidManifest.xml
<!-- Branch URI Scheme -->
<intent-filter>
<data
android:host="open"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move it to the config as well? 🤔

volodymyr-chekyrta
volodymyr-chekyrta reviewed Feb 28, 2024
View reviewed changes
app/src/main/java/org/openedx/app/AppActivity.kt
Comment on lines +167 to +168
if (viewModel.isBranchEnabled) {
if (intent?.getBooleanExtra(BRANCH_FORCE_NEW_SESSION, false) == true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about combining these two into one `if'?

@HamzaIsrar12 HamzaIsrar12 linked an issue Mar 1, 2024 that may be closed by this pull request
[Android] Third-party Deep Links tool SDK integration #203
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta left review comments

@omerhabib26 omerhabib26 omerhabib26 approved these changes

@k1rill k1rill k1rill left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Third-party Deep Links tool SDK integration
4 participants
@HamzaIsrar12 @k1rill @omerhabib26 @volodymyr-chekyrta