fix: bug when video continues to play when exiting content #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 5, 2024
volodymyr-chekyrta
approved these changes
Mar 5, 2024
k1rill
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue on Android where 'Fragment.onDestroy()' is not called after one fragment was replaced with another using the 'FragmentManager.replace()' function without 'addToBackStack()'. And after a long discussion with @volodymyr-chekyrta we decided to make a workaround for this issue.
All new CourseUnitContainerFragment instances will be added with 'addToBackStack()' and then to go to the previous fragment we need to find it and call 'popBackStack(previousFragmentTagName)'.
Using this workaround, also, was fixed a bug where the 'Back to outline' button would not work.