fix: crash after rotating device in open content #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-chekyrta
previously approved these changes
Mar 9, 2024
farhan-arshad-dev
previously approved these changes
Mar 12, 2024
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitFragment.kt
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/video/EncodedVideoUnitViewModel.kt
Outdated
Show resolved
Hide resolved
dixidroid
dismissed stale reviews from farhan-arshad-dev and volodymyr-chekyrta
via
5682db4
farhan-arshad-dev
approved these changes
Mar 14, 2024
k1rill
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 crashes in one case - when the web page has loaded but the fragment has already been detached and when the CastContext is not ready
Fixed both